Sunday Breakout Strategy

[ridedivefx]

Phil, I have been following your thread for a while but never asked anything as all my questions were answered in detailed

My first Q to you: The EA you posted is for EURJPY and GBPJPY will any of these also run onthe GBPUSD? or are you posting another one for that - just confused

thanks

[phil838]

Originally Posted by ridedivefx

Phil, I have been following your thread for a while but never asked anything as all my questions were answered in detailed

My first Q to you: The EA you posted is for EURJPY and GBPJPY will any of these also run onthe GBPUSD? or are you posting another one for that - just confused

thanks

Oops... My mistake.

The GBP/JPY was for testing only. I abandoned it and moved to EUR/JPY a long time ago. I put it in there instead of GBP/USD by accident.

I'm editing the post and putting up the correct EAs now. Whatever you do don't use that GBP/JPY EA!!!! It will lose money, if it even works...

[phil838]

The correct EAs are up now, I edited the post where I originally uploaded them.

[ridedivefx]

Originally Posted by phil838

The correct EAs are up now, I edited the post where I originally uploaded them.

thanks much appreciated

[Oskar]

Thanks Phil.
DL it from your first post, hope it is the one, unless you posted it somewhere else.

[phil838]

Originally Posted by Oskar

Thanks Phil.
DL it from your first post, hope it is the one, unless you posted it somewhere else.

It's on post #970. Here's a link...Sunday Breakout Strategy

I'm not putting it up on the first post until I'm sure it works without errors.

If I put it on the first post I'm scared newbies will grab it without reading our ongoing discussions and then start complaining because they lost money.

So just in case anyone hasn't gotten the message yet, don't use the EA on a live account yet!!! Let's all demo (or .01 lot live trade) it for a couple weeks to work out the bugs, then we'll use it on real money.

[s050399b]

Originally Posted by phil838

I couldn't get the timezone offset or the 4/5 decimal detection to work right, so I'm posting it as-is. Hopefully s05 or someone else can fix those problems, since I've included the source code.

I'll take a look at it,

[s050399b]

Originally Posted by phil838

if (DayOfWeek() == 1 && TimeHour(TimeCurrent()) == 0 && TimeMinute(TimeCurrent()) == 0)

Wow!! this is a better way of writing it!!
I learnt something!

[s050399b]

Well done phil838!! Everything looks great!!

btw, there's no need for magic number because we have keep track of the order ticket number!!



What I can suggest is that to:-
1) remove unneccessary code
2) heavily comment the code
3) putting in more checks to handle user errors; example, 0.02 or 2%, checking lot size is reasonable, etc.......more like unit test the code
4) remove opposite pending order when current ATR is 40% of weekly 14 ATR
5) remove opposite pending order when it has reached wednesday
6) GMT Offset
7) 4 digit to 5 digit broker conversion

[s050399b]

Hi phil838,

When do we move the SL to BE for EURJPY?