[WIP] Cowabunga MT4 Expert Advisor

[kepler]

Hello there,
I'm trying to write the code in order to create a "Cowabunga Expert Advisor" for MetaTrader 4 platform. Starting from the indicator i found here - Cowabunga.mq4 - (sorry, I don't remember the author) I wrote some functions, defined the buy and sell market enters, and for simplicity for now the program closes a position when you are gaining or loosing 20 pips (obviously this is not the Cowabunga system, but I want to test the first part of the code for now).
I've tried to test the advisor into MT but it seems not working as expected, you can download the file CowabungaEA.mq4 and verify it on your own: it opens a lot of positions and closing them immediatly, and NOT when the original Cowabunga indicator shows the arrow signal. I made some mistakes (I'm not an expert programmer)!

If someone that can do the work could help me... It would be useful for many of us, I think

[craigfx]

Glad to see someone is working on an EA. Maybe someone can help fill in the gaps to make it work. Good-Luck

[kepler]

Originally Posted by craigfx

Glad to see someone is working on an EA. Maybe someone can help fill in the gaps to make it work. Good-Luck

That's what I hope. Sorry but I'm not really good programming, I'm doing my best to do this stuff work, but I need a help...

[eight10]

Well those lines of a Billion > < == %% || statements makes its almost impossible to comprehend what is going on. I also prefer to make seperate functions to control the program, instead of lumping everything in the start().

for instance you could do something like

int stochCross(double stoch1, double stoch2)
{
   static int direction = 0;
   static int new_direction = 0;
   
   if(stoch 1> stoch2)
       direciton = 1;
   if(stoch 1 < stoch 2)
       direciton = -1;

   if(direction != new_direction)
   {
        new_direction = direction;
        return(new_direction);
    }
return(0);
}

From there in start just reference:
signal = stochCross(stoch1, stoch2);
then from there something like
if(signal == 1)
placeorder;
etc.
makes for less messy code, and code that people can read. Also eliminates the need for current_stoch and previous_stoch.

[kepler]

Hello Eight, thank you for the reply!
You are right, the code will be more readable with some sub-funcions, I will re-write all the stuff soon; for the moment I've corrected a lot of stupid errors I made before and now it seems to be working as expected (regarding the market-entry section).

Stay tuned.

[tegasite]

we are waiting impatiently
is it going to take foever?????????????/

Originally Posted by kepler

Hello Eight, thank you for the reply!
You are right, the code will be more readable with some sub-funcions, I will re-write all the stuff soon; for the moment I've corrected a lot of stupid errors I made before and now it seems to be working as expected (regarding the market-entry section).

Stay tuned.