# Help me program a simple EA?

I’m trying to learn a little programming.

Is there a simple moving average crossover EA that I could look at the code and see how it is coded?

I tried to write one but I’m getting errors when it tries to send the buy or sell order and I would like to see the code of one that works. Doesn’t matter if it’s profitable or not, I just want to see how the code works. Simpler is better for my limited knowledge of mql4

here’s a place for TONS of indicators. I don’t know how good any of them are…but if for some reason I need an indy that I don’t have I go here.

Hi

I have attached a simple crossover EA, Buys when price moves up and through the 200 sma, sells when price moves down and through the 200sma

i’m currectly trying to get a custom indicator to work with this too.
if you could help that would be great email

//±-----------------------------------------------------------------+
//| Swing Raider v0.9.mq4 |
//| Copyright � 2008, Reg Jones. |
//±-----------------------------------------------------------------+
#define MAGICMA 20050610

extern double Lots = 0.1;
extern double MaximumRisk = 0.02;
extern double DecreaseFactor = 3;
extern double MovingPeriod = 200;
extern double MovingShift = 0;
//±-----------------------------------------------------------------+
//| Calculate open positions |
//±-----------------------------------------------------------------+
int CalculateCurrentOrders(string symbol)
{
//----
for(int i=0;i<OrdersTotal();i++)
{
if(OrderSymbol()==Symbol() && OrderMagicNumber()==MAGICMA)
{
if(OrderType()==OP_SELL) sells++;
}
}
//---- return orders volume
else return(-sells);
}
//±-----------------------------------------------------------------+
//| Calculate optimal lot size |
//±-----------------------------------------------------------------+
double LotsOptimized()
{
double lot=Lots;
int orders=HistoryTotal(); // history orders total
int losses=0; // number of losses orders without a break
//---- select lot size
lot=NormalizeDouble(AccountFreeMargin()MaximumRisk/1000.0,1);
//---- calcuulate number of losses orders without a break
if(DecreaseFactor>0)
{
for(int i=orders-1;i>=0;i–)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) { Print(“Error in history!”); break; }
if(OrderSymbol()!=Symbol() || OrderType()>OP_SELL) continue;
//----
if(OrderProfit()>0) break;
if(OrderProfit()<0) losses++;
}
if(losses>1) lot=NormalizeDouble(lot-lot
losses/DecreaseFactor,1);
}
//---- return lot size
if(lot<0.1) lot=0.1;
return(lot);
}
//±-----------------------------------------------------------------+
//| Check for open order conditions |
//±-----------------------------------------------------------------+
void CheckForOpen()
{
double ma;
int res;
//---- go trading only for first tiks of new bar
if(Volume[0]<1) return;
//---- get Moving Average
ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
//---- sell conditions
if(Open[1]>ma && Close[1]<ma)
{
res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,0,0,"",MAGICMA,0,Red);
return;
}
if(Open[1]<ma && Close[1]>ma)
{
return;
}
//---- sell conditions
if(Volume[0]>1) return;
ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
if(Open[1]<ma && Close[1]>ma)
{
res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,0,0,"",MAGICMA,0,Red);
return;
}
if(Open[1]>ma && Close[1]<ma)
{
return;
}
//----
}
//±-----------------------------------------------------------------+
//| Check for close order conditions |
//±-----------------------------------------------------------------+
void CheckForClose()
{
double ma;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
//----
for(int i=0;i<OrdersTotal();i++)
{
if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
//---- check order type
{
if(Open[1]>ma && Close[1]<ma) OrderClose(OrderTicket(),OrderLots(),Bid,3,White);
break;
}
if(OrderType()==OP_SELL)
{
break;
}
}
//----
}
//±-----------------------------------------------------------------+
//| Start function |
//±-----------------------------------------------------------------+
void start()
{
//---- check for history and trading