Excellent ea just need some adjustments

knauffmichael · March 15, 2013, 7:13pm

hi works excellent but make only 1 dollar profits and cant seem to change it

#property copyright “”
#property link “”
#define buy -5
#define sell 5
//---- input parameters

extern double tp_in_money=1.0;
extern double range=40;
extern double fastEMA=10;
extern double slowEMA=20;
extern double macdSMA=7;
extern double UpperMACd_Filter=0.0010;
extern double LowerMACd_Filter=-0.0010;

extern double start_lot=0.01;
extern bool lot_multiplier=true;
extern double multiplier=2.0;
extern double increament=0.01;
extern bool use_daily_target=false;
extern double daily_target=100;
extern bool EachTickMode = false;
extern bool trade_in_fri=true;
extern int magic=1;
extern int level=5;

extern bool use_sl_and_tp=false;
extern double sl=60;
extern double tp=30;

extern bool stealth_mode=false;

double pt;
double minlot;
double stoplevel;
int prec=0;
int a=0;
int ticket=0;

int BarCount;
int Current;
bool TickCheck = False;

//±-----------------------------------------------------------------+
//| expert initialization function |
//±-----------------------------------------------------------------+
int init()
{
//----

BarCount = Bars;
if (EachTickMode) Current = 0; else Current = 1;

if(Digits==3 || Digits==5) pt=10*Point;
else pt=Point;
minlot = MarketInfo(Symbol(),MODE_MINLOT);
stoplevel=MarketInfo(Symbol(),MODE_STOPLEVEL);
if(start_lot<minlot) Print(“lotsize is to small.”);
if(sl<stoplevel) Print(“stoploss is to tight.”);
if(tp<stoplevel) Print(“takeprofit is to tight.”);
if(minlot==0.01) prec=2;
if(minlot==0.1) prec=1;
//----
return(0);
}
//±-----------------------------------------------------------------+
//| expert deinitialization function |
//±-----------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//±-----------------------------------------------------------------+
//| expert start function |
//±-----------------------------------------------------------------+
int start()
{
if(use_daily_target && dailyprofit()>=daily_target)
{
Comment("
daily target achieved.");
return(0);
}
if(!trade_in_fri && DayOfWeek()==5 && total()==0)
{
Comment("
stop trading in Friday.");
return(0);
}
if(total()==0 && a==0)
{
if(signal()==buy)
{
if(stealth_mode)
{
if(use_sl_and_tp) ticket=OrderSend(Symbol(),0,start_lot,Ask,3,Ask-slpt,Ask+tppt,"",magic,0,Blue);
else ticket=OrderSend(Symbol(),0,start_lot,Ask,3, 0, 0,"",magic,0,Blue);
}
else
{
if(use_sl_and_tp)
{
if(OrderSend(Symbol(),0,start_lot,Ask,3,Ask-slpt,Ask+tppt,"",magic,0,Blue)>0)
{
for(int i=1; i<level; i++)
{
if(lot_multiplier) ticket=OrderSend(Symbol(),2,NormalizeDouble(start_lotMathPow(multiplier,i),prec),Ask,3,(Ask-(rangei)pt)-slpt,(Ask-(rangei)pt)+tppt,"",magic,0,Blue);
else ticket=OrderSend(Symbol(),2,NormalizeDouble(start_lot+increamenti,prec) ,Ask,3,(Ask-(rangei)pt)-slpt,(Ask-(rangei)pt)+tppt,"",magic,0,Blue);
}
}
}
else
{
if(OrderSend(Symbol(),0,start_lot,Ask,3,0,0,"",magic,0,Blue)>0)
{
for(i=1; i<level; i++)
{
if(lot_multiplier && signal()==buy) ticket=OrderSend(Symbol(),2,NormalizeDouble(start_lotMathPow(multiplier,i),prec),Ask,3,0,0,"",magic,0,Blue);
else if (signal()==buy) ticket=OrderSend(Symbol(),2,NormalizeDouble(start_lot+increamenti,prec) ,Ask,3,0,0,"",magic,0,Blue);
}
}
}
}
}
if(signal()==sell)
{
if(stealth_mode)
{
if(use_sl_and_tp) ticket=OrderSend(Symbol(),1,start_lot,Bid,3,Bid+slpt,Bid-tppt,"",magic,0,Red);
else ticket=OrderSend(Symbol(),1,start_lot,Bid,3, 0, 0,"",magic,0,Red);
}
else
{
if(use_sl_and_tp)
{
if(OrderSend(Symbol(),1,start_lot,Bid,3,Bid+slpt,Bid-tppt,"",magic,0,Red)>0)
{
for(i=1; i<level; i++)
{
if(lot_multiplier) ticket=OrderSend(Symbol(),3,NormalizeDouble(start_lotMathPow(multiplier,i),prec),Bid,3,(Bid+(rangei)pt)+slpt,(Bid+(rangei)pt)-tppt,"",magic,0,Red);
else ticket=OrderSend(Symbol(),3,NormalizeDouble(start_lot+increamenti,prec) ,Bid,3,(Bid+(rangei)pt)+slpt,(Bid+(rangei)pt)-tppt,"",magic,0,Red);
}
}
}
else
{
if(OrderSend(Symbol(),1,start_lot,Bid,3,0,0,"",magic,0,Red)>0)
{
for(i=1; i<level; i++)
{
if(lot_multiplier) ticket=OrderSend(Symbol(),3,NormalizeDouble(start_lotMathPow(multiplier,i),prec),Bid ,3,0,0,"",magic,0,Red);
else ticket=OrderSend(Symbol(),3,NormalizeDouble(start_lot+increamenti,prec) ,Bid ,3,0,0,"",magic,0,Red);
}
}
}
}
}
}

//// TOTAL > 0 ///////////////////////////////////////////////////////

if(stealth_mode && total()&gt;0 && total()&lt;level)

 {
 int type; double op, lastlot; 
 for(i=0; i&lt;OrdersTotal(); i++)
 {
     OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
     if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic) continue;
     type=OrderType();
     op=OrderOpenPrice();
     lastlot=OrderLots();
 }
 
 if(signal2()==buy)
   
 if(type==0 && Ask&lt;=op-range*pt) 
 
 if(type==0) 
 
 {
    if(use_sl_and_tp)
    {
       if(lot_multiplier) ticket=OrderSend(Symbol(),0,NormalizeDouble(lastlot*multiplier,prec),Ask,3,Ask-sl*pt,Ask+tp*pt,"",magic,0,Blue);
       else               ticket=OrderSend(Symbol(),0,NormalizeDouble(lastlot+increament,prec),Ask,3,Ask-sl*pt,Ask+tp*pt,"",magic,0,Blue);
    }
    else
    {
       if(lot_multiplier) ticket=OrderSend(Symbol(),0,NormalizeDouble(lastlot*multiplier,prec),Ask,3,0,0,"",magic,0,Blue);
       else               ticket=OrderSend(Symbol(),0,NormalizeDouble(lastlot+increament,prec),Ask,3,0,0,"",magic,0,Blue);
    }
 }

//

 if(signal2()==sell)
 
 if(type==1 && Bid&gt;=op+range*pt)
 
 if(type==1)
 {
    if(use_sl_and_tp)
    {
       if(lot_multiplier) ticket=OrderSend(Symbol(),1,NormalizeDouble(lastlot*multiplier,prec),Bid,3,Bid+sl*pt,Bid-tp*pt,"",magic,0,Red);
       else               ticket=OrderSend(Symbol(),1,NormalizeDouble(lastlot+increament,prec),Bid,3,Bid+sl*pt,Bid-tp*pt,"",magic,0,Red);
    }
    else
    {
       if(lot_multiplier) ticket=OrderSend(Symbol(),1,NormalizeDouble(lastlot*multiplier,prec),Bid,3,0,0,"",magic,0,Red);
       else               ticket=OrderSend(Symbol(),1,NormalizeDouble(lastlot+increament,prec),Bid,3,0,0,"",magic,0,Red);
    }
 }

}
if(use_sl_and_tp && total()>1)
{
double s_l, t_p;
for(i=0; i<OrdersTotal(); i++)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || OrderType()>1) continue;
type=OrderType();
s_l=OrderStopLoss();
t_p=OrderTakeProfit();
}
for(i=OrdersTotal()-1; i>=0; i–)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || OrderType()>1) continue;
if(OrderType()==type)
{
if(OrderStopLoss()!=s_l || OrderTakeProfit()!=t_p)
{
OrderModify(OrderTicket(),OrderOpenPrice(),s_l,t_p,0,CLR_NONE);
}
}
}
}
double profit=0;
for(i=0; i<OrdersTotal(); i++)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic || OrderType()>1) continue;
profit+=OrderProfit();
}
if(profit>=tp_in_money || a>0)
{
closeall();
closeall();
closeall();
a++;
if(total()==0) a=0;
}
if(!stealth_mode && use_sl_and_tp && total()<level) closeall();
//----

//----
return(0);
}
//±-----------------------------------------------------------------+
double dailyprofit()
{
int day=Day(); double res=0;
for(int i=0; i<OrdersHistoryTotal(); i++)
{
OrderSelect(i,SELECT_BY_POS,MODE_HISTORY);
if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic) continue;
if(TimeDay(OrderOpenTime())==day) res+=OrderProfit();
}
return(res);
}
//±-----------------------------------------------------------------+
int total()
{
int total=0;
for(int i=0; i<OrdersTotal(); i++)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic) continue;
total++;
}
return(total);
}
//±-----------------------------------------------------------------+
int signal()
{

double macB = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_OPEN, MODE_MAIN, 0);

double Buy1_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_OPEN, MODE_MAIN, Current + 0);
double Buy1_2 = 0;
double Buy2_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 2);
double Buy2_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 2);
double Buy3_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 1);
double Buy3_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 1);

double Sell1_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_OPEN, MODE_MAIN, Current + 0);
double Sell1_2 = 0;
double Sell2_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 2);
double Sell2_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 2);
double Sell3_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 1);
double Sell3_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 1);

if (Buy1_1 < Buy1_2 && Buy2_1 < Buy2_2 && Buy3_1 > Buy3_2 && macB < LowerMACd_Filter) return(buy);

if (Sell1_1 > Sell1_2 && Sell2_1 > Sell2_2 && Sell3_1 < Sell3_2 && macB > UpperMACd_Filter) return(sell);

}
return(0);

//±-----------------------------------------------------------------+
int signal2()
{

double macB = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_OPEN, MODE_MAIN, 0);

double Buy1_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_OPEN, MODE_MAIN, Current + 0);
double Buy1_2 = 0;
double Buy2_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 2);
double Buy2_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 2);
double Buy3_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 1);
double Buy3_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 1);

double Sell1_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_OPEN, MODE_MAIN, Current + 0);
double Sell1_2 = 0;
double Sell2_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 2);
double Sell2_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 2);
double Sell3_1 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_MAIN, Current + 1);
double Sell3_2 = iMACD(NULL, 0, fastEMA, slowEMA, macdSMA , PRICE_CLOSE, MODE_SIGNAL, Current + 1);

if (Buy1_1 < Buy1_2 && Buy2_1 < Buy2_2 && Buy3_1 > Buy3_2) return(buy);

if (Sell1_1 > Sell1_2 && Sell2_1 > Sell2_2 && Sell3_1 < Sell3_2) return(sell);

}
return(0);

//±-----------------------------------------------------------------+

void closeall()
{
for(int i=OrdersTotal()-1; i>=0; i–)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber()!=magic) continue;
if(OrderType()>1) OrderDelete(OrderTicket());
else
{
if(OrderType()==0) OrderClose(OrderTicket(),OrderLots(),Bid,3,CLR_NONE);
else OrderClose(OrderTicket(),OrderLots(),Ask,3,CLR_NONE);
}
}
}

CodeMeister · March 15, 2013, 8:24pm

You can adjust the settings to try to find a better combination. But don’t waste much time on it, because MA crossovers isn’t a winning strategy. If you understood trading you would understand why.

knauffmichael · March 16, 2013, 2:04am

interesting seeing as its a macd and in one year on dailies its produced 63 wins and 0 loses but i guess you didnt know that cause you didnt try it did you?and changing combinations wont do anything because its the tp in money thats the issue,its only taking 1 dollar profits and i need it in pips
another cause of someone with abit of authority pushing his weight,my name only say newbie cause i recently joined

CodeMeister · March 16, 2013, 3:26am

Welcome to the forum noobie. I am sure you will be a welcome addition.:rolleyes:

Just so that you know, I don’t rate people by their join dates, but by the content of their postings.

And no I don’t waste my time downloading the garbage posted here unless the person makes a compelling case for me to invest my effort.

knauffmichael · March 16, 2013, 3:34am

well so far from your posts you are insulting something you havent even tried,getting a good picture of your from your posts to…

zangon · March 16, 2013, 3:38am

Thank u. I believe it will be to my benefit been a newbie sir. Thank u.

monsterer · March 16, 2013, 1:49pm

Just change tp_in_money from 1.0 to your desired take profit amount?

[B]edit: be careful with this EA - its another one which just trades and then holds and prays without stop-loss, which is why the results look too good to be true - they are :)[/B]

Cheers, Paul.

ClarkFX · March 16, 2013, 10:10pm

Not hard to just skim over the code to know what it’s doing… By the looks of it, it’d be better not to invest too much time into it…

alualdi · May 2, 2013, 11:43am

can you please add the file? as when i complie it it gives many errors
thanks

[QUOTE=knauffmichael;469423]hi works excellent but make only 1 dollar profits and cant seem to change it

#property copyright “”
#property link “”
#define buy -5
#define sell 5
//---- input parameters